Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-select appears to add to the selection, but does not draw the selection halo around all items. #635

Closed
Bonkles opened this issue Oct 31, 2022 · 1 comment
Closed

Multi-select appears to add to the selection, but does not draw the selection halo around all items. #635

Bonkles opened this issue Oct 31, 2022 · 1 comment
Assignees
@Bonkles
Labels
bug Something isn't working
Milestone
v2 Alpha 3

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Oct 31, 2022 •
edited
Loading

Tried multi-select, it sort of works.

Image

In the above pic, I shift+selected the three nodes in the lower right starting with the intersection, yield sign, and then crosswalk.

The sidebar showed three separate selections (good!) but no item text (bad!) Also, only the first item I shift-clicked remained selected.
@Bonkles Bonkles added this to the v2 Alpha 3 milestone Oct 31, 2022
@Bonkles Bonkles mentioned this issue Dec 13, 2022
Closed
Bonkles added a commit that referenced this issue Dec 13, 2022
@Bonkles
Fix #635 by ensuring that we class every item in the context selectio…
c22d733 
…n, not just the first one.
@Bonkles Bonkles self-assigned this Dec 13, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Dec 13, 2022

Fixed in c22d73347. We were only considering the first item in the selection when rendering.

multiselect_now_working.mov

@Bonkles Bonkles closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bonkles Bonkles

Labels
bug Something isn't working
Projects
Rapid v2 Beta Board
Status: Pending Release
Milestone
v2 Alpha 3
Development

No branches or pull requests
1 participant
@Bonkles