Square function bug on areas

[Mapiate]

Description

Using the Square function on areas either by right clicking or using the hotkey Q does not work as expected. There seems to be a delay and does not render until additional actions take place, like adding or deleting nodes, or moving the area. Trying to use the Square option again, is then disabled.

New Building where the Square function was used but did not show the new shape.

When using the Move function, the new shape then displays but leaves behind traces of the nodes.

I was able to reproduce this consistently in Firefox and Chrome.

Version

2.00-alpha.3

What browser are you seeing the problem on? What version are you running?

Firefox v107.0

Steps to reproduce

Create a new building.
Right click or use the Q hotkey to use the Square.

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha3#background=MAPNIK&datasets=fbRoads,msBuildings&disable_features=points,indoor,landuse,boundaries,rail,pistes,aerialways,past_future&id=w-5&map=19.00/43.41944/-71.95998

[bhousel]

Thanks! There is a tricky bug that I'm working on this week where sometimes geometries get cached and not redrawn properly to reflect how they should look after edits happen. I've noticed this with circularizing too, and also across undoing-redoing edits. Hope to have a fix for this pretty soon.

[Bonkles]

Thanks for the report! I'll add a little context here- after squaring the building the first time, RapiD's in-memory representation of the building has been updated to be square. When you right-click again, the square option isn't available because RapiD thinks the shape is square.

This causes understandable user confusion, because RapiD hasn't redrawn the shape to look square.

If you were to hit the browser reload button and keep your changes, you would see the squared building get rendered correctly.

UPDATE: It looks like this bears further scrutiny. Even after squaring a building and refreshing rapid / keeping changes, the unsquare building is still displayed. ?!?!?!?!

[cbeddow]

@Bonkles not sure if related, but when I draw something new even, a swimming pool here, I cannot square it (edit: refresh shows the squared one though after I submit the change): https://mapwith.ai/rapid-v2-alpha3#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries,past_future,others&map=21.18/25.76330/-80.13800

[Bonkles]

After a little testing on my own this morning, it does indeed look like there's an issue with building squaring beyond the 'we didn't redraw it correctly'. I will dig in more for sure!

[Bonkles]

Update to the update- nope, square has the same bug that circularize, rotate, etc. all have right now. That is, until the fix we just pushed!

Fixed in alpha 3.2 release that just went live.