Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/redo button causes node and way to separate/does not properly return features to previous state #703

Closed
csm2023 opened this issue Dec 6, 2022 · 1 comment
Assignees
Milestone

Comments

@csm2023
Copy link

csm2023 commented Dec 6, 2022

Description

Way node becomes separated from the way when using undo/redo buttons, particularly after disconnecting ways. In the image, the node in the lower right is the end node of one of the sidewalks, and should have returned to its original position at the intersection of the ways after the undo/redo button was used. EDIT: This actually occurs mostly anytime a feature is moved, not just with disconnecting ways.
Screen Shot 2022-12-06 at 1 59 04 PM

Version

2.00-alpha.3

What browser are you seeing the problem on? What version are you running?

Chrome v108.0

Steps to reproduce

To recreate: Select a way node where two ways intersect, press d to disconnect. Move the node away from original position. Click elsewhere on the map to deselect it. Then, use the undo button. The node will return to its original position while the line of the way remains in the new position. If you press undo again, the line will return, but if you redo it after that, the way and node get separated again. Continued use of undo/redo after completing other actions can also cause the ways to get stuck in place while still separated from their node (The undo button eventually greys out so the way can't be returned to the previous state).

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-alpha3#background=Bing&datasets=fbRoads,msBuildings&disable_features=points,indoor,landuse,boundaries,water,rail,pistes,aerialways,power,past_future,others&map=19.54/39.66977/-105.16100

@Bonkles
Copy link
Contributor

Bonkles commented Dec 13, 2022

This bug is fixed in newer versions of the alpha- specifically ver 2.00-alpha.3.2. See bug #682 for an explanation of what was going on here.

@Bonkles Bonkles closed this as completed Dec 13, 2022
@Bonkles Bonkles added this to the v2 Alpha 3 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending Release
Development

No branches or pull requests

3 participants