Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't start a line from the most recently drawn line #797

Closed
bhousel opened this issue Feb 14, 2023 · 0 comments
Closed

Can't start a line from the most recently drawn line #797

bhousel opened this issue Feb 14, 2023 · 0 comments
Assignees
@bhousel
Labels
bug Something isn't working

Comments

@bhousel
Copy link
Contributor

bhousel commented Feb 14, 2023

This is a weird bug where some state (activeData) was getting kept around between draws.
The effect was that when you start a new line, it wouldn't allow you to hover or continue from the line you just previously drew.

cant hover
@bhousel bhousel added the bug Something isn't working label Feb 14, 2023
@bhousel bhousel self-assigned this Feb 14, 2023
bhousel added a commit that referenced this issue Mar 2, 2023
@bhousel
Fix: Can't start a line from the most recently drawn line
11b45ef 
(fixes #797)

The fix for this was really to clear _activeData, which is a collection we use
almost the same as the 'drawing' class.  They might be redundant?

Also includes a few other things that turned out not to be the issue
but could have caused other bugginess:
- in BehaviorHover, don't compare null to undefined
- in ModeDrawArea/ModeDrawLine clear the 'drawing' class in
  exit() (guaranteed to be called) instead of finish()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhousel bhousel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhousel