Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typechecking issue with Python 3.10 #308

Closed
wants to merge 1 commit into from

Conversation

davide125
Copy link
Member

What:

Fix a typechecking error when building TestSlide on Python 3.10 that was found in Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1981718).

Why:

testslide/runner.py:288: error: Incompatible types in assignment (expression has type "BaseException", variable has type "Union[Exception, AggregatedExceptions]")
Found 1 error in 1 file (checked 26 source files)
make: *** [Makefile:87: mypy] Error 1

How:

Adding the missing type

Risks:

It's typechecking

Checklist:

  • Added tests, if you've added code that should be tested N/A
  • Updated the documentation, if you've changed APIs N/A
  • Ensured the test suite passes
  • Made sure your code lints
  • Completed the Contributor License Agreement ("CLA")

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 13, 2021
@deathowl
Copy link
Member

Thanks, as a follow up i'll add 3.10 to the build matrix. And I'll import this PR

@facebook-github-bot
Copy link

@deathowl has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1026915321

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.181%

Totals Coverage Status
Change from base Build 953161056: 0.0%
Covered Lines: 2606
Relevant Lines: 2767

💛 - Coveralls

@facebook-github-bot
Copy link

@deathowl merged this pull request in 8b0c16c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants