Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI run against proper python 3.10 #337

Closed
wants to merge 2 commits into from
Closed

Make CI run against proper python 3.10 #337

wants to merge 2 commits into from

Commits on Aug 5, 2022

  1. Remove strict_mock check for existing instances, aas removing gc.coll… 

    …ect made it unstable

Summary: Certain weird usecases would require us to call gc.collect(), but that makes the eventloop , so is not a good option. This is a good enough compromise

Differential Revision: D38455488

fbshipit-source-id: 98634feff1a2fd150b0ef1e65c52db96ea5444a6
    @deathowl @facebook-github-bot
    deathowl authored and facebook-github-bot committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    6a70a6f View commit details
    Browse the repository at this point in the history

  2. Make CI run against proper python 3.10 (facebook#337) 

    Summary:
Pull Request resolved: facebook#337

Python 3.10 was released for a while now, let's move CI to 3.10 from 3.10-dev

Reviewed By: lsiudut

Differential Revision: D38455626

fbshipit-source-id: 3dea5996ba79e5c8d9b875097c7198fceca18f6f
    @deathowl @facebook-github-bot
    deathowl authored and facebook-github-bot committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    5bef5ce View commit details
    Browse the repository at this point in the history