Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add exported_linker_flags to cgo_library #2177

Open
linzhp opened this issue Jan 31, 2019 · 1 comment
Open

Add exported_linker_flags to cgo_library #2177

linzhp opened this issue Jan 31, 2019 · 1 comment
Labels
golang P3 Priority 3

Comments

@linzhp
Copy link
Contributor

linzhp commented Jan 31, 2019

Now cgo_library can take C files in its srcs, we should add exported_linker_flags too, so the linker flags can be passed down to the final linking stage. Alternatives, we may pass all linker flags of cgo_library to all rules that transitively depend on it.

@mkaczanowski What do you think?

@mkaczanowski
Copy link

I don't mind having exported_linker_flags in cgo_library (that is already a customized cxx_library flavor). Feel free to come up with PR

@v-jizhang v-jizhang added the P3 Priority 3 label Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
golang P3 Priority 3
Projects
None yet
Development

No branches or pull requests

3 participants