buck build creates buck-{bin,gen} but buck clean does not delete them

[spearce]

I am trying to upgrade our build to f158d62 + my patches so we can start using buckd. In doing so I discovered outputs are now going to buck-gen rather than buck-out/gen. OK fine, but buck clean should remove buck-gen.

[bolinfest]

Internally, we have legacy code that writes to buck-bin and buck-gen directories. Up until now, we have kept the public version of Buck clear of this using MOE:begin_strip, but apparently we missed some places.

I want to assign this to Jim (who is responsible for the buckd stuff), but GitHub doesn't seem to let me do that.

[jimpurbrick]

f158d62 has a buck_common script which isn't MOE scrubbed, which is why it's using the internal buck-{bin.gen} directories. CleanCommand.java in that commit is correctly scrubbed, which is why clean isn't removing buck-{bin,gen}. I fixed the export scripts to properly scrub the new buck_common and buckd scripts last night, so if you use any of the commits exported yesterday you should see the old buck-out/gen behaviour and clean working properly. Alternatively manually removing the MOE block from buck_common in f158d62 should fix it for you.

[bolinfest]

I believe this is fixed by 1dbf407 where we eliminated the use of buck-bin and buck-gen internally. Please reopen if this is not the case.