Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Allow Buck to run without Android SDK #7

Closed
spearce opened this issue Apr 29, 2013 · 4 comments
Closed

Allow Buck to run without Android SDK #7

spearce opened this issue Apr 29, 2013 · 4 comments
Assignees
@bolinfest

Comments

@spearce
Copy link
Contributor

spearce commented Apr 29, 2013

Add a new option to .buckconfig that indicates the project does not need the Android SDK. Disabling the Android SDK check allows Buck to run for normal Java projects that only need java_library(), java_binary(), and prebuilt_jar().
@bolinfest
Copy link
Contributor

Thanks for filing: this is definitely an oversight on our part. Buck is meant to be able to support "pure Java" projects, as well as Android projects.

@ghost ghost assigned bolinfest Apr 29, 2013
@spearce
Copy link
Contributor Author

spearce commented May 1, 2013

If you are interested in looking at a real world pure Java project's usage of Buck, see https://gerrit.googlesource.com/gerrit/+/57a4d597cd1111ebabf9bbf495ecd45324e7acdd as it contains a complete, non-trivial "pure Java" project build system alongside of the existing Maven build.

I unfortunately had to use 22 genrules() to provide a number of hacks for features missing from Buck. The worst hack of all was committing local.properties to work around the Android SDK. :-)

@bolinfest
Copy link
Contributor

I have a fix for this internally, but I'm waiting for a code review :(

On Wed, May 1, 2013 at 10:02 AM, Shawn O. Pearce
notifications@github.comwrote:

If you are interested in looking at a real world pure Java project's usage
of Buck, see
https://gerrit.googlesource.com/gerrit/+/57a4d597cd1111ebabf9bbf495ecd45324e7acddas it contains a complete, non-trivial "pure Java" project build system
alongside of the existing Maven build.

I unfortunately had to use 22 genrules() to provide a number of hacks for
features missing from Buck. The worst hack of all was committing
local.properties to work around the Android SDK. :-)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-17292098
.

@bolinfest
Copy link
Contributor

Fixed:
ef014b3

runningcode pushed a commit to runningcode/buck that referenced this issue May 24, 2017
Merge pull request facebook#7 in ANDROID/buck from no/merge-upstream …
c2777b1 
…to master

* commit '5860f1ccb114d2a1786748603a444996debd09f6': (680 commits)
  Fix crash building Android rules
  Ignore classes within anonymous or local classes
  Fix annotations on inner class constructor params
  Enable `abi_verification_mode=fail`
  Fix stubs for deeply-nested static inner classes
  Fix references to deeply-nested enums
  Close cache at the end of cache command
  Add ndk.extra_ldflags
  Refactor creation of NDK ldflags
  Handle race conditions in Buck project constructor.
  ClassLoaderBootstrapper: Create ClassLoader earlier
  Stop logging "No Android platform target specified" to console
  JarBuilder: Eliminate checkNotNull
  Add more info for cannot delete directory failures
  AndroidLibraryDescription: Move ABI rule construction into the builder
  AndroidLibraryDescription: Move graph enhancement into the builder
  AndroidLibraryDescription: Push provided_deps_query into the builder
  DefaultJavaLibraryBuilder: Factor out getJavac
  DefaultJavaLibraryBuilder: Make initial BuildRuleParams accessible to subclasses
  Plumb TargetGraph and CellPathResolver into DefaultJavaLibraryBuilder
  ...
Lcsmarcal pushed a commit to Lcsmarcal/buck that referenced this issue Oct 20, 2020
@andre-alves-ifood
Remove test scheme changes in SchemeGenerator (facebook#7)
2e0023a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bolinfest bolinfest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spearce @bolinfest