-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Parameters for annotation processors are disabled and undocumented #85
Comments
Actually, it looks like this feature is excluded from the open-source version of Buck because we weren't ready to finalize the API. I'll see if we're ready now. |
Thanks, I would suggest that having to list the annotation processors is a pain for users. There were actually 3 different ones in the problem I was trying to track down. |
Unfortunately, using the processorpath option disables that behavior. I don't think it would be safe to put the AbiProcessor on the classpath during compilation. This is probably one of the issues that made the original authors (my co-workers) think that it wasn't ready for widespread use. |
Could we not expose a mean to add additional processorpath entries? |
Are we not ready to expose annotation_processors, etc? |
AutoValue[1] is a lightweight annotation-processor-based library for implementing classes with simple, obvious value semantics. Add support for AutoValue to build rules and Eclipse project generation. Buck does not currently have an officially-supported interface for specifying annotation processor dependencies[2], so we have to take the slightly ugly approach of monkey-patching java_library and java_test to add annotation processor arguments to each rule that requires annotation processing; hopefully this ugliness can be reduced in the future. [1] https://github.com/google/auto/tree/master/value [2] facebook/buck#85 Change-Id: I8b49d6f9f25d61688b667d964848c6ce106ae4ec
These are now available: They're still undocumented though. |
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
What I wonder: FB does use a code review system: (phabricator?) internally? At least we see, "Reviewed By:" footer in commit messages. So how comes that those lines: https://github.com/facebook/buck/blame/master/src/com/facebook/buck/jvm/java/JavaBuckConfig.java#L81-L83 added by this commit: 97a8dc0 missing documentation bits? Was that intended not to be documented? In which case i would expect that commit message states that this config options intentionally not documented. |
We do use code review. We do frequently leave options undocumented if we think they aren't ready for public consumption. You're right that it would probably be a good idea to state that explicitly in the commit messages. |
Any update around annotation processing feature being available in open source version? Can't get this to work |
cc @jkeljo |
Hi, this issue is closed because it has not been updated for over 3 years. Thanks |
android_library and java_library support the arguments "annotation_processors", "annotation_processor_deps", "annotation_processor_params", and "annotation_processor_only". Currently these are undocumented.
The text was updated successfully, but these errors were encountered: