This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Fix Appstore Connect publication #2549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-jizhang
reviewed
Sep 30, 2020
| @@ -2362,6 +2361,7 @@ private boolean shouldEmbedSwiftRuntimeInBundleTarget( | |||
| // a Swift runtime, so it must get bundled to ensure they run. | |||
| return true; | |||
|
|
|||
| case APPEX: | |||
There was a problem hiding this comment.
This essentially prevent buck from setting ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to YES. And it does more things other than just not creating the Frameworks directory. I don't feel very confident about this PR. Do we have any other solutions? Thanks
A similar issue: CocoaPods/CocoaPods#4203
|
This PR is closed because no updates for 2 weeks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should not be a Framewrok directory inside an app plugin to publish the IPA file to the Appstore Connect: