Implement a build_config generator. #95
Conversation
Summary: This change set adds a build_config generator that knows how to generate the BuildConfig.java files generated by existing build tools. This addresses issue: #3 and is based on the strategy proposed in the comment on that issue. Test Plan: There are already unit tests in place which verify all but the contents of the generated file. To verify contents add a build_config rule to a project and dig into buck-out to verify the contents of the file are correct.
|
Note that I signed the CLA already. Let me know if there are any issues there. |
|
Hey, sorry for the radio silence on this one. We're in the process of pulling it, and we'll post an update here when that's done. Thanks for the code! (And for making it a described rule, that really helps.) |
Summary: Simplified the build steps a bit. Use ProjectFilesystem in GenerateBuildConfigStep, and try-with-resources. Use System.lineSeparator() for platform independent newlines. Make field final. Cleaned up unnecessary getter methods. Simplified creating buildable/build rule in the unit test. Fixed styling. I will follow up with another diff that updates the soy docs. Test Plan: buck test --all
|
Pulled in 4c3b7f4 |
Summary: Simplified the build steps a bit. Use ProjectFilesystem in GenerateBuildConfigStep, and try-with-resources. Use System.lineSeparator() for platform independent newlines. Make field final. Cleaned up unnecessary getter methods. Simplified creating buildable/build rule in the unit test. Fixed styling. I will follow up with another diff that updates the soy docs. Test Plan: buck test --all
|
Hi @nickpalmer, I ended up deleting |
|
Nice optimization. I am glad Facebook gives you guys the time to focus on these issues! 👍 |
|
@nickpalmer updated the pull request. |
Summary:
This change set adds a build_config generator that knows how to
generate the BuildConfig.java files generated by existing build tools.
This addresses issue: #3
and is based on the strategy proposed in the comment on that issue.
Test Plan:
There are already unit tests in place which verify all but the
contents of the generated file. To verify contents add a build_config
rule to a project and dig into buck-out to verify the contents
of the file are correct.