-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
erlang: migrate test runner to json from term specs
Summary: This switches test runner from using term test specs to using JSON. This should help lower memory pressure from buck2 when running tests since constructing the test specs as terms turned out pretty expensive in other cases. The other changes are related to the fact that now we pass-in data as binaries rather than strings. In particular the `erl` command was concatenated into a single string on buck side, only to be re-split on the erlang side - instead we pass it in as an array of strings now. Additionally, I switched code loading of hooks to be more assertive - before it would fail silently and then result in suspicious failures - failing early makes it much easier to understand what's going on. Writing the test spec file was simplified to do just one IO operation, rather than a sequence of writes for key config value. Reviewed By: TD5 Differential Revision: D59328376 fbshipit-source-id: 9c9e3373babea50741c89bbddf3315104847f0ed
- Loading branch information
1 parent
36f8af2
commit 6c0aa04
Showing
8 changed files
with
50 additions
and
60 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters