New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime error (seem to be caused by link error) #267
Comments
Same error here on Ubuntu 20.04 when running: after: git clone https://github.com/facebook/CacheLib |
@wangyuyue @siphonelee Thanks for the report. We are working on the fix. Thanks |
@jaesoo-fb Thank you for the help. I met the same issue before. At this time,
|
As reported in facebook#267, we are seeing the runtime error which is caused by fbthrift change 8c2dfbbe50d7 (Allow padding in SimpleJSONProtocol base64 encoded binary fields). This change fixes the fbthrift to the lastest tag v2023.10.09.00 before the offending change.
Summary: This is an alternative diff to D50521352, that simply removes the gflag causing the [issue](facebook/CacheLib#267). This is likely an inferior option, since it removes the option for users to opt ouf of the new behavior of ignoring padding in base64. However, while this was technically a breaking change, since previously the base64 decoder would append garbage bytes to the end of the input in the presence of padding, it seems unlikely that anyone depended on this corruption. Reviewed By: vitaut, jaesoo-fb Differential Revision: D50568555 fbshipit-source-id: bdebd070bd1d620c653d619317e9898eac049ca5
Fixed by fbthrift change 0f3b4bf922b7 (Remove gflag in JSONProtocolCommon) |
Summary: This is an alternative diff to D50521352, that simply removes the gflag causing the [issue](facebook/CacheLib#267). This is likely an inferior option, since it removes the option for users to opt ouf of the new behavior of ignoring padding in base64. However, while this was technically a breaking change, since previously the base64 decoder would append garbage bytes to the end of the input in the presence of padding, it seems unlikely that anyone depended on this corruption. Reviewed By: vitaut, jaesoo-fb Differential Revision: D50568555 fbshipit-source-id: bdebd070bd1d620c653d619317e9898eac049ca5
Summary: As discovered in #267, current workflow cannot detect runtime link error. This change adds the step to run a cachebench with simple configuration as a test for the build. Reviewed By: therealgymmy Differential Revision: D50667376 fbshipit-source-id: f19ebcdfb894ef43e7286dc3565ae8e00c1b1a03
Describe the bug
Runtime error (seem to be caused by link error)
To Reproduce
Expected behavior
Run example program successfully
Output
ERROR: something wrong with flag 'thrift_cpp2_simple_json_base64_allow_padding' in file '/users/glacier/CacheLib/cachelib/external/fbthrift/thrift/lib/cpp2/protocol/JSONProtocolCommon.cpp'. One possibility: file '/users/glacier/CacheLib/cachelib/external/fbthrift/thrift/lib/cpp2/protocol/JSONProtocolCommon.cpp' is being linked both statically and dynamically into this executable.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: