Only apply the remaining violation to flexible children #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @ocrickard to be a potential reviewer. |
|
I'm going to import this change to kick off the internal snapshot tests. @facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
|
I'll follow up with a snapshot test case tomorrow. |
|
@eczarny updated the pull request - view changes - changes since last import |
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
CKStackLayoutComponentwas incorrectly applying the remaining violation to inflexible children. Not good. Instead the remaining violation should only be applied to flexible children that specify a flex grow factor.