Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically create and test webpack config #118

Closed
chrisvfritz opened this issue Jul 23, 2016 · 2 comments
Closed

Programmatically create and test webpack config #118

chrisvfritz opened this issue Jul 23, 2016 · 2 comments

Comments

@chrisvfritz
Copy link

I love that you have an e2e test to confirm that it basically works. 😄 One of the biggest issues I've encountered with templates I maintain is the difficult of making changes as they grow more complex. As you expand and perhaps include optional features, this may be a good time to start producing the webpack configs programmatically, with e2e tests for each individual feature (and combination of features).

A resource that may be helpful is maintainable-webpack-config. It's a very immature experiment in programmatically producing a validated and tested Webpack config. May be useful as inspiration.

@mxstbr mxstbr changed the title Full(ish) test coverage for build features Programmatically create and test webpack config Jul 23, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Jul 23, 2016

I'm generally against providing an abstraction on top of webpack. There's lots of those projects around that aim to make webpack config "easier", and if it floats your boat you can definitely use them after ejecting!

@gaearon
Copy link
Contributor

gaearon commented Jul 29, 2016

Thanks for the suggestion! We will stick with a “vanilla” config because people will want to customize it after ejecting, and we don’t want to lock them into using a third-party project for that.

@gaearon gaearon closed this as completed Jul 29, 2016
@andriijas andriijas mentioned this issue Feb 26, 2018
23 tasks
grengojbo pushed a commit to grengojbo/es6-react-scripts that referenced this issue Jun 6, 2018
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants