Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for jsx extension #116

Closed
wants to merge 2 commits into from
Closed

Added support for jsx extension #116

wants to merge 2 commits into from

Conversation

dolchi21
Copy link

Apply babel loader to jsx files so that sublime and github can automatically display jsx code correctly.

Apply babel loader to jsx files so that sublime and github can automatically display jsx code correctly
@ghost
Copy link

ghost commented Jul 22, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

Can you please see my reply in #87?

You can configure Sublime to use Babel syntax scheme for .js extension. It works much better than the old JSX scheme and supports both JSX and Flow just fine.

Similarly, if GitHub treats .jsx specially, it is worth filing this with GitHub. Majority of React open source projects don't use .jsx extension anymore so it doesn't really make a lot of sense if GitHub still cares about the extension.

@dolchi21
Copy link
Author

i just read it. you convinced me. it's time to change my default js syntax in sublime.

@dolchi21 dolchi21 closed this Jul 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 3, 2016

FYI we support JSX extension since 0.4.1 even though we don’t recommend it.
Read the release notes.

@dolchi21
Copy link
Author

dolchi21 commented Sep 3, 2016

Thank you very much for taking the time to notify the news!
I have already deprecated the use of jsx extension following your advise.

kalekseev pushed a commit to kalekseev/create-react-app that referenced this pull request Sep 11, 2017
grengojbo pushed a commit to grengojbo/es6-react-scripts that referenced this pull request Jun 6, 2018
grengojbo pushed a commit to grengojbo/es6-react-scripts that referenced this pull request Jun 6, 2018
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants