Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jest 26 #8954

Closed
ianschmitz opened this issue May 4, 2020 · 3 comments · Fixed by #8955
Closed

Jest 26 #8954

ianschmitz opened this issue May 4, 2020 · 3 comments · Fixed by #8955
Assignees
@ianschmitz
Labels
issue: needs investigation
Milestone
4.0

Comments

@ianschmitz
Copy link
Contributor

Jest 26 will be released in the next few days it sounds like. We should aim to get this in with our 4.0 release.
@ianschmitz ianschmitz added this to the 4.0 milestone May 4, 2020
@ianschmitz ianschmitz self-assigned this May 4, 2020
@ianschmitz ianschmitz mentioned this issue May 4, 2020
Merged
1 task
@SimenB
Copy link
Contributor

SimenB commented May 9, 2020

Thoughts on shipping with jest-circus by default? We're going to do that in Jest 27, so would make you forward compatible 🙂 We'll also change default testEnvironment to node, but I think you already specify this(?)

@ianschmitz
Copy link
Contributor Author

I'll give it a go @SimenB and see if we run into any issues!

@timini
Copy link

timini commented May 11, 2020

any idea when the 4.0 release will be?

@LiamMyles LiamMyles mentioned this issue May 13, 2020
Closed
5 tasks
grahamhoyes added a commit to ieeeuoft/hackathon-template that referenced this issue Jun 5, 2020
@grahamhoyes
Upgrade to JSDOM v16
1226657 
Fixes a `MutationObserver shim removed` error in testing with
findBy*. This is a temporary patch until the next version of
create-react-app upgrades to Jest 26. A few issues about that,
such as facebook/create-react-app#8954
and facebook/create-react-app#8362.

This workaround is from
https://github.com/testing-library/dom-testing-library/releases/tag/v7.0.0
grahamhoyes added a commit to ieeeuoft/hackathon-template that referenced this issue Jun 7, 2020
@grahamhoyes
Add unconnected login form and page (#21)
4097670 
* Install formik and yup

* Remove started login page

* Global square corners for inputs

* Login form and page WIP

* Mixins to match MUI's

* Clean up the login page

* Make available

* Upgrade testing-library to the latest version

* Upgrade to JSDOM v16

Fixes a `MutationObserver shim removed` error in testing with
findBy*. This is a temporary patch until the next version of
create-react-app upgrades to Jest 26. A few issues about that,
such as facebook/create-react-app#8954
and facebook/create-react-app#8362.

This workaround is from
https://github.com/testing-library/dom-testing-library/releases/tag/v7.0.0

* Login form tests

* Loading wheel on login

* Fix App.test.js

* Move header into the page components

* Login page tests

* Button hover cover

* Plug our colors into MUI's theme

* Less padding for small screens

* Fix handling of scss exports in testing
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianschmitz ianschmitz

Labels
issue: needs investigation
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Upgrade to Jest 26 ianschmitz/create-react-app
3 participants
@timini @SimenB @ianschmitz