Add unconnected login form and page #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a `MutationObserver shim removed` error in testing with findBy*. This is a temporary patch until the next version of create-react-app upgrades to Jest 26. A few issues about that, such as facebook/create-react-app#8954 and facebook/create-react-app#8362. This workaround is from https://github.com/testing-library/dom-testing-library/releases/tag/v7.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a login form and page that currently don't do anything, pending being hooked up to Redux in a separate PR. The form is at
/login.The form itself uses formik to handle all the React form magic, and yup for the form validation.
Also moved the header component into the Dashboard page, so that it could selectively be rendered on the login page without the navigation links.
Once this is hooked up to redux, should check if the user is already logged in and send them to the home page if so (conversely, if they aren't logged in on the home page, send them here. Should do this by making an API request and getting 401'd).
React Testing Library and JSDOM were updated to allow for some cool new ways of testing formik (which handles everything asyncronously) with RTL's
waitFor.