Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cache clear to e2e scripts #2400

Merged
merged 3 commits into from May 29, 2017

Conversation

Projects
None yet
3 participants
@ro-savage
Copy link
Contributor

commented May 28, 2017

Fixes #2399

Yarn is caching old react-scripts when running the e2e tests, which means old versions are being used during the build process. Fine for CI where each build is on a clean machine but breaks e2e in unforeseen ways on local machines.

This might be related to yarnpkg/yarn#2165

The fix is to run yarn clean cache before running the e2e tests.

@gaearon

This comment has been minimized.

Copy link
Member

commented May 28, 2017

Looks like that command doesn't work on AppVeyor.
Probably yarnpkg/yarn#2591.

Worth trying yarnpkg/yarn#2591 (comment)?

@ro-savage

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2017

Issue is fixed in latest version of yarn, so decide best thing to do is just install the latest version of yarn. Once AppVeyor updates their yarn, the npm install -g yarn can be removed.

AppVeyor issue: appveyor/ci/issues/1576

However, now there is a new issue related to #2030. Might be caused by using the latest version of yarn on windows machines.

Could either wait for the fix or try change this PR to use the work around gaearon mentioned.

# Workaround for https://github.com/yarnpkg/yarn/issues/2591
case "$(uname -s)" in
  *CYGWIN*|MSYS*|MINGW*) yarn=yarn.cmd;;
  *) yarn=yarn;;
esac
eval $yarn run build

@ro-savage ro-savage referenced this pull request May 29, 2017

Closed

Yarn 0.24.6 #1576

@ro-savage

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2017

Updated to apply the yarn=yarn.cmd fix, rather than installing the latest yarn which causes issues else where. The latest version of yarn + cra + windows 10 issue can be dealt with in #2030

@ro-savage ro-savage force-pushed the ro-savage:e2e-cache-fix branch from c848a97 to 171e8fc May 29, 2017

@gaearon gaearon merged commit 32f82c0 into facebook:master May 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaearon gaearon added this to the 1.0.8 milestone May 29, 2017

zangrafx added a commit to zangrafx/create-react-app that referenced this pull request May 31, 2017

Merge branch 'master' into zangrafx
* master:
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)

kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request May 31, 2017

Merge branch 'master' into serve-app-under
* master:
  Fix docs typo (facebook#2420)
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)
  Update README.md for `now` deployments (facebook#2372)
  Print file sizes with correct build folder path. (facebook#2361)
  Fix broken links (facebook#2350)
  Update webpack to v2.6.0 in react-scripts (facebook#2349)

@gaearon gaearon referenced this pull request Jun 26, 2017

Closed

Try to fix AppVeyor CI #2626

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Is this hack still necessary? AppVeyor has been failing for a while now. I tried reverting this in #2626 but it doesn't help. I'm super confused.

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

christensena added a commit to christensena/create-react-app that referenced this pull request Jul 8, 2017

Added cache clear to e2e scripts (facebook#2400)
* Added cache clear to e2e scripts

* Install latest yarn on AppVeyor to avoid windows crashing bug in yarn

* Alternative fix for yarn crashing e2e tests on windows machines

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Added cache clear to e2e scripts (facebook#2400)
* Added cache clear to e2e scripts

* Install latest yarn on AppVeyor to avoid windows crashing bug in yarn

* Alternative fix for yarn crashing e2e tests on windows machines

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Added cache clear to e2e scripts (#2400)
* Added cache clear to e2e scripts

* Install latest yarn on AppVeyor to avoid windows crashing bug in yarn

* Alternative fix for yarn crashing e2e tests on windows machines

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.