Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sourcemap directory organizing on Windows (#2456) #2610

Merged
merged 2 commits into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@plusCubed
Copy link
Contributor

commented Jun 24, 2017

Chrome devtools doesn't recognize Windows file paths with backslashes. This is a naive fix, replacing backslashes with forward slashes. I tried looking for a more generalized path function that did this, but didn't find any.

Before:
before

After:
after

Fixes #2456.

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 24, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 24, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added the tag: bug fix label Jun 24, 2017

@Timer Timer added this to the 1.0.8 milestone Jun 24, 2017

@Timer

Timer approved these changes Jun 24, 2017

Copy link
Collaborator

left a comment

LGTM! Thanks!

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Jun 24, 2017

Do you know if there's a chrome bug report open about this?

@plusCubed

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2017

So apparently source-maps are supposed to refer to URLs (mozilla/source-map#91 and source map spec), which is why the backslash doesn't work. I don't think this is a Chrome-specific thing. I've updated the comments.

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Looks good, thanks!

@gaearon gaearon merged commit a9ac789 into facebook:master Jun 27, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Fix sourcemap directory organizing on Windows (facebook#2456) (facebo…
…ok#2610)

* Fix sourcemap directory organizing on Windows

* Update comments

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Fix sourcemap directory organizing on Windows (#2456) (#2610)
* Fix sourcemap directory organizing on Windows

* Update comments

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Fix sourcemap directory organizing on Windows (facebook#2456) (facebo…
…ok#2610)

* Fix sourcemap directory organizing on Windows

* Update comments

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.