-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class fields to stage 3 #2908
Class fields to stage 3 #2908
Conversation
Per 2017.07.27 TC39 tc39/proposals@0bbbb08
One caveat is that Babel doesn’t implement the “private fields” part which is a part of stage 3 proposal. |
The merge with private fields took place two months ago, while it was still at stage 2. The link also refers to the obsolete proposal (before the merge). @gaearon Would you like me to add "Public" to the link description, to make it "Public Class Fields and Static Properties"? |
Maybe we can say "(part of stage 3 proposal)" |
@gaearon Done. But it isn't clear what part is implemented until you follow the link. So I would still suggest to add "Public" to the link description. I also don't know if there is any change between the stage 2 and stage 3 specification regarding the public fields (haven't checked yet). |
This LGTM; I believe the current link is fair since babel has no support for the private modifier yet. |
* Class fields to stage 3 Per 2017.07.27 TC39 tc39/proposals@0bbbb08 * Be explicit that only the public part of the unified field proposal is available.
* Class fields to stage 3 Per 2017.07.27 TC39 tc39/proposals@0bbbb08 * Be explicit that only the public part of the unified field proposal is available.
* Class fields to stage 3 Per 2017.07.27 TC39 tc39/proposals@0bbbb08 * Be explicit that only the public part of the unified field proposal is available.
…react-app * 'master' of https://github.com/facebookincubator/create-react-app: Make error overlay to run in the context of the iframe (facebook#3142) Fix Windows compatibility (facebook#3232) Fix package management link in README (facebook#3227) Watch for changes in `src/**/node_modules` (facebook#3230) More spec compliant HTML template (facebook#2914) Minor change to highlight dev proxy behaviour (facebook#3075) Correct manual proxy documentation (facebook#3185) Improve grammar in README (facebook#3211) Publish Fix license comments Changelog for 1.0.14 BSD+Patents -> MIT (facebook#3189) Add link to active CSS modules discussion (facebook#3163) Update webpack-dev-server to 2.8.2 (facebook#3157) Part of class fields to stage 3 (facebook#2908) Update unclear wording in webpack config docs (facebook#3160) Display pid in already running message (facebook#3131) Link local react-error-overlay package in kitchensink test
…pescript * 'master' of https://github.com/wmonk/create-react-app-typescript: (265 commits) fix typo in changelog Update README For 2.13.0 v2.13.0 Remove tslint-loader from prod build (again) Include TypeScript as devDependency in boilerplate output Documented how to define custom module formats for the TypeScript compiler so that you can import images and other files (references wmonk#172) v2.12.0 Update README For 2.12.0 Update typescript to 2.6.2 v2.11.0 Update changelog for 2.11.0 Fixed problem with tsconfig.json baseUrl and paths Update createJestConfig.js Update changelog for 2.10.0 v2.10.0 Readd transformIgnorePatterns Update react-dev-utils Update package.json dependencies Readd Missing raf Package Update JestConfig Creation Fix Fix Missing Variable Fix package.json Merge pull request wmonk#204 from StefanSchoof/patch-1 Merge pull request wmonk#201 from StefanSchoof/patch-1 Merge pull request wmonk#199 from DorianGrey/master Merge pull request wmonk#165 from johnnyreilly/master Publish Add 1.0.17 changelog (#3402) Use new WebpackDevServer option (#3401) Fix grammar in README (#3394) Add link to VS Code troubleshooting guide (#3399) Update VS Code debug configuration (#3400) Update README.md (#3392) Publish Reorder publishing instructions Changelog for 1.0.16 (#3376) Update favicon description (#3374) Changelog for 1.0.15 (#3357) Replace template literal; fixes #3367 (#3368) CLI@1.4.2 Publish Add preflight CWD check for npm (#3355) Stop using `npm link` in tests (#3345) Fix for add .gitattributes file #3080 (#3122) Mention that start_url needs to be "." for client side routing start using npm-run-all to build scss and js (#2957) Updating the Service Worker opt-out documentation (#3108) Remove an useless negation in registerServiceWorker.js (#3150) Remove output.path from dev webpack config (#3158) Add `.mjs` support (#3239) Add documentation for Enzyme 3 integration (#3286) Make uglify work in Safari 10.0 - fixes #3280 (#3281) Fix favicon sizes value in manifest (#3287) Bump dependencies (#3342) recommend react-snap; react-snapshot isn't upgraded for React 16 (#3328) Update appveyor.cleanup-cache.txt Polyfill rAF in test environment (#3340) Use React 16 in development Use a simpler string replacement for the overlay Clarify the npm precompilation advice --no-edit Update `eslint-plugin-react` (#3146) Add jest coverage configuration docs (#3279) Update link to Jest Expect docs (#3303) Update README.md Fix dead link to Jest "expect" docs (#3289) v2.8.0 Use production React version for bundled overlay (#3267) Add warning when using `react-error-overlay` in production (#3264) Add external links to deployment services (#3265) `react-error-overlay` has no dependencies now (#3263) Add click-to-open support for build errors (#3100) Update style-loader and disable inclusion of its HMR code in builds (#3236) Update url-loader to 0.6.2 for mime ReDoS vuln (#3246) Make error overlay to run in the context of the iframe (#3142) Upgrade to typescript 2.5.3 Fix Windows compatibility (#3232) Fix package management link in README (#3227) Watch for changes in `src/**/node_modules` (#3230) More spec compliant HTML template (#2914) Minor change to highlight dev proxy behaviour (#3075) Correct manual proxy documentation (#3185) Improve grammar in README (#3211) Publish Fix license comments Changelog for 1.0.14 BSD+Patents -> MIT (#3189) Add link to active CSS modules discussion (#3163) Update webpack-dev-server to 2.8.2 (#3157) Part of class fields to stage 3 (#2908) Update unclear wording in webpack config docs (#3160) Display pid in already running message (#3131) Link local react-error-overlay package in kitchensink test Resolved issue #2971 (#2989) Revert "run npm 5.4.0 in CI (#3026)" (#3107) Updated react-error-overlay to latest Flow (0.54.0) (#3065) Auto-detect running editor on Linux for error overlay (#3077) Clean target directory before compiling overlay (#3102) Rerun prettier and pin version (#3058) ...
* Class fields to stage 3 Per 2017.07.27 TC39 tc39/proposals@0bbbb08 * Be explicit that only the public part of the unified field proposal is available.
Per 2017.07.27 TC39
tc39/proposals@0bbbb08