Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to core-js@3 #6769

Merged
merged 4 commits into from Apr 14, 2019

Conversation

@ianschmitz
Copy link
Collaborator

commented Apr 7, 2019

This is a breaking change to our 3.0 alpha that deprecates the @babel/polyfill feature in favor of the recommended approach from the babel team as part of the babel 7.4.0 release. This adds a new react-app-polyfill/stable module that can be imported from src/index.js which will include polyfills for stable language features, and integrates nicely with @babel/preset-env which uses browserslist to only include polyfills for the target browsers.

Some more relevant info on this change: https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md#babel

Outstanding questions:

  • In the corejs@2 migration guide it says
    • If you are using @babel/plugin-transform-runtime, you need to use the corejs: 3 option

    • We currently have corejs: false so my sense is we can ignore this, but it would be helpful if someone with more knowledge of this plugin could chime in

@ianschmitz ianschmitz added this to the 3.0 milestone Apr 7, 2019

@ianschmitz ianschmitz added this to In progress in v3 via automation Apr 7, 2019

@mrmckeb

mrmckeb approved these changes Apr 7, 2019

Update packages/react-app-polyfill/README.md
Co-Authored-By: ianschmitz <ianschmitz@gmail.com>

@ianschmitz ianschmitz merged commit bffc296 into facebook:master Apr 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Apr 14, 2019

@ianschmitz ianschmitz deleted the ianschmitz:corejs-update branch Apr 14, 2019

@brunolemos

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2019

There is no react-app-polyfill/stable in the published version.

"react-app-polyfill": "1.0.0-next.b0cbf2ca",
"react-scripts": "3.0.0-next.b0cbf2ca",
@ianschmitz

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 15, 2019

This was just merged in recently @brunolemos. We will publish a new alpha shortly.

@iansu iansu referenced this pull request Apr 17, 2019

@lock lock bot locked and limited conversation to collaborators Apr 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
5 participants
You can’t perform that action at this time.