Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #7662

Merged
merged 4 commits into from
Sep 9, 2019
Merged

Fix build #7662

merged 4 commits into from
Sep 9, 2019

Conversation

ianschmitz
Copy link
Contributor

@ianschmitz ianschmitz commented Sep 9, 2019

Fixes build and closes #7566.

There seemed to be some strange yarn workspace hoisting issues here with babel/eslint packages. Also ran into some flow type errors but decided to disable typings on those files as the error overlay is going to be rewritten anyways, and disabled flow entirely on Windows agents as it was crashing.

@ianschmitz ianschmitz merged commit 1f46136 into facebook:master Sep 9, 2019
@ianschmitz ianschmitz deleted the fix-build branch September 9, 2019 01:20
This was referenced Sep 9, 2019
VasilyShelkov pushed a commit to VasilyShelkov/create-react-extension that referenced this pull request Sep 9, 2019
@lock lock bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint for...in / for...of false positive
2 participants