Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnswatch] add readme and CI #30

Closed
wants to merge 1 commit into from
Closed

Conversation

deathowl
Copy link
Member

@deathowl deathowl commented May 9, 2023

Add CI Lint and Readme for DNSWatch

  • Added tests, if you've added code that should be tested
  • Updated the documentation, if you've changed APIs
  • Ensured the test suite passes
  • Made sure your code lints
  • Completed the Contributor License Agreement ("CLA")

@facebook-github-bot
Copy link
Contributor

@deathowl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.20 ⚠️

Comparison is base (d958460) 65.14% compared to head (f3da261) 58.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   65.14%   58.95%   -6.20%     
==========================================
  Files          59       69      +10     
  Lines        6766     8172    +1406     
==========================================
+ Hits         4408     4818     +410     
- Misses       2080     3036     +956     
- Partials      278      318      +40     
Impacted Files Coverage Δ
dnswatch/snoop/filter.go 38.46% <ø> (ø)
dnswatch/snoop/probe.go 16.37% <ø> (ø)
dnswatch/snoop/prometheus_exporter.go 0.00% <0.00%> (ø)
dnswatch/snoop/snoop.go 29.26% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@deathowl deathowl force-pushed the main branch 4 times, most recently from 35fbcc4 to f3da261 Compare May 10, 2023 12:45
@facebook-github-bot
Copy link
Contributor

@deathowl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@deathowl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@deathowl merged this pull request in f6a1707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants