Add rel="noreferrer noopener" to <a> with target="_blank" (#531)

* Add rel="noreferrer noopener" to <a> with target="_blank" * Run Prettier
facebook · Apr 8, 2018 · e19b9ac · e19b9ac
1 parent c2cd169
commit e19b9ac
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 10 deletions.
diff --git a/examples/basics/core/Footer.js b/examples/basics/core/Footer.js
@@ -52,11 +52,15 @@ class Footer extends React.Component {
             </a>
             <a
               href="http://stackoverflow.com/questions/tagged/"
-              target="_blank">
+              target="_blank"
+              rel="noreferrer noopener">
               Stack Overflow
             </a>
             <a href="https://discordapp.com/">Project Chat</a>
-            <a href="https://twitter.com/" target="_blank">
+            <a
+              href="https://twitter.com/"
+              target="_blank"
+              rel="noreferrer noopener">
               Twitter
             </a>
           </div>
@@ -80,6 +84,7 @@ class Footer extends React.Component {
         <a
           href="https://code.facebook.com/projects/"
           target="_blank"
+          rel="noreferrer noopener"
           className="fbOpenSource">
           <img
             src={this.props.config.baseUrl + 'img/oss_logo.png'}

diff --git a/lib/core/BlogPost.js b/lib/core/BlogPost.js
@@ -44,7 +44,7 @@ class BlogPost extends React.Component {
     if (post.authorFBID) {
       return (
         <div className={className}>
-          <a href={post.authorURL} target="_blank">
+          <a href={post.authorURL} target="_blank" rel="noreferrer noopener">
             <img
               src={
                 'https://graph.facebook.com/' +
@@ -59,7 +59,7 @@ class BlogPost extends React.Component {
     } else if (post.authorImage) {
       return (
         <div className={className}>
-          <a href={post.authorURL} target="_blank">
+          <a href={post.authorURL} target="_blank" rel="noreferrer noopener">
             <img src={post.authorImage} />
           </a>
         </div>
@@ -110,7 +110,10 @@ class BlogPost extends React.Component {
         <div className="authorBlock">
           {post.author ? (
             <p className="post-authorName">
-              <a href={post.authorURL} target="_blank">
+              <a
+                href={post.authorURL}
+                target="_blank"
+                rel="noreferrer noopener">
                 {post.author}
               </a>
               {post.authorTitle}

diff --git a/lib/core/Doc.js b/lib/core/Doc.js
@@ -31,7 +31,11 @@ class Doc extends React.Component {
       this.props.metadata.custom_edit_url ||
       (this.props.config.editUrl && this.props.config.editUrl + docSource);
     let editLink = editUrl && (
-      <a className="edit-page-link button" href={editUrl} target="_blank">
+      <a
+        className="edit-page-link button"
+        href={editUrl}
+        target="_blank"
+        rel="noreferrer noopener">
         {editThisDoc}
       </a>
     );
@@ -50,7 +54,8 @@ class Doc extends React.Component {
             '/' +
             this.props.language
           }
-          target="_blank">
+          target="_blank"
+          rel="noreferrer noopener">
           {translateThisDoc}
         </a>
       );

diff --git a/lib/core/nav/HeaderNav.js b/lib/core/nav/HeaderNav.js
@@ -46,7 +46,10 @@ class LanguageDropDown extends React.Component {
     if (siteConfig.translationRecruitingLink) {
       enabledLanguages.push(
         <li key="recruiting">
-          <a href={siteConfig.translationRecruitingLink} target="_blank">
+          <a
+            href={siteConfig.translationRecruitingLink}
+            target="_blank"
+            rel="noreferrer noopener">
             {helpTranslateString}
           </a>
         </li>

diff --git a/website/core/Footer.js b/website/core/Footer.js
@@ -92,8 +92,8 @@ class Footer extends React.Component {
         <a
           href="https://code.facebook.com/projects/"
           target="_blank"
-          className="fbOpenSource"
-        >
+          rel="noreferrer noopener"
+          className="fbOpenSource">
           <img
             src={`${this.props.config.baseUrl}img/oss_logo.png`}
             alt="Facebook Open Source"