Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launching Docusaurus V2 as installed PWA on Windows just shows manifest.json instead of the site #3447

Closed
krillboi opened this issue Sep 14, 2020 · 2 comments 路 Fixed by #3500
Closed

Launching Docusaurus V2 as installed PWA on Windows just shows manifest.json instead of the site #3447

krillboi opened this issue Sep 14, 2020 · 2 comments 路 Fixed by #3500
Labels
bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. hacktoberfest help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@krillboi
Copy link

krillboi commented Sep 14, 2020 •
edited
Loading

馃悰 Bug Report

After installing v2.docusaurus.io as a PWA on Windows through Chrome and then relaunching it, I am just greeted with the manifest.json file. See gif below:

pwa-bug

Have you read the Contributing Guidelines on issues?

Yes.

To Reproduce

  1. Navigate to v2.docusaurus.io through Chrome.
  2. Press the + button to install the site as a PWA.
  3. Close the app.
  4. Launch the app.
  5. manifest.json appears.

Expected behavior

The app should show the site and not just the manifest.json file.

Actual Behavior

The manifest.json file is shown.

Your Environment

  • Docusaurus version used: alpha.64.
  • Environment name and version: Chrome Version 83.0.4103.61.
  • Operating system and version (desktop or mobile): Windows 10 Version 10.0.17763 Build 17763

Reproducible Demo

Can be tested through v2.docusaurus.io.
@krillboi krillboi added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Sep 14, 2020
@ashscodes
Copy link
Contributor

ashscodes commented Sep 15, 2020 •
edited
Loading

I've test this in the new Microsoft Edge on Windows 10 and in Chrome/Microsoft Edge on MacOS and it's doing the same thing. Our personal app is working. I suspect it might be an issue in the manifest.json file here manifest.json#L7. I think the scope and start_url should both be "/".

@lex111 lex111 added good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. hacktoberfest and removed status: needs triage This issue has not been triaged by maintainers labels Sep 30, 2020
@slorber
Copy link
Collaborator

slorber commented Sep 30, 2020

Thanks, you are right.

Tried to find a solution here so that our deploy preview under baseurl still work to install/test the PWA setup: https://deploy-preview-3438--docusaurus-2.netlify.app/classic/

But apparently this broken both after you relaunch the app 馃槄

@slorber slorber mentioned this issue Sep 30, 2020
Merged
@slorber slorber linked a pull request Sep 30, 2020 that will close this issue
fix(v2): fix Docusaurus 2 website PWA manifest #3500
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. hacktoberfest help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(v2): fix Docusaurus 2 website PWA manifest facebook/docusaurus
4 participants
@slorber @lex111 @krillboi @ashscodes