Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

"footer.logo.alt" is not allowed to be empty #3816

Closed
aarongarciah opened this issue Nov 25, 2020 · 2 comments 路 Fixed by #3817
Closed

"footer.logo.alt" is not allowed to be empty #3816

aarongarciah opened this issue Nov 25, 2020 · 2 comments 路 Fixed by #3817
Labels
bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@aarongarciah
Copy link
Contributor

馃悰 Bug Report

This is exactly the same issue as #3350, but this time in the footer config instead of the navbar config.

When I use an empty string for footer.logo.alt in my config, I get the following validation error:

ValidationError: "footer.logo.alt" is not allowed to be empty

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

  1. Create a new Docusarus v2 project.
  2. Set footer.logo.alt in themeConfig in docusaurus.config.js to ''.
  3. Run npm start.

Expected behavior

The website to start just fine with the footer logo having an empty alt="" attribute.

Actual Behavior

The site doesn't compile and an error is shown in the terminal output:

A validation error occured.
The validation system was added recently to Docusaurus as an attempt to avoid user configuration errors.
We may have made some mistakes.
If you think your configuration is valid and should keep working, please open a bug report.

ValidationError: "footer.logo.alt" is not allowed to be empty

Your Environment

  • Docusaurus version used: 2.0.0-alpha.69
  • Environment name and version: Node v12.19.0
  • Operating system and version: macOS 10.15.7

Reproducible Demo

  1. Clone https://github.com/aarongarciah/docusaurus-footer-logo-alt
  2. yarn install
  3. yarn start
  4. Check the terminal output and see the ValidationError: "footer.logo.alt" is not allowed to be empty error

Or with a CodeSandbox account:

  1. Go to https://codesandbox.io/s/nice-torvalds-y57bu?file=/docusaurus.config.js
  2. Fork the sandbox
  3. Check the terminal output (once it finishes installing dependencies) and see the ValidationError: "footer.logo.alt" is not allowed to be empty error
@aarongarciah aarongarciah added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Nov 25, 2020
@slorber slorber added good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. and removed status: needs triage This issue has not been triaged by maintainers labels Nov 25, 2020
@iamrubayet
Copy link

can i work on this ??????

@aarongarciah
Copy link
Contributor Author

can i work on this ??????

@iamrubayet this was solved via #3817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants