Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOC item should not be highlighted if below the viewport #5318

Closed
pranabdas opened this issue Aug 8, 2021 · 3 comments 路 Fixed by #5361
Closed

TOC item should not be highlighted if below the viewport #5318

pranabdas opened this issue Aug 8, 2021 · 3 comments 路 Fixed by #5361
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@pranabdas
Copy link
Contributor

pranabdas commented Aug 8, 2021 •
edited

馃挜 Proposal

The first TOC item is highlighted/active even it is below the viewport. I think the first item should be highlighted once it is scrolled inside viewport.

TOC_active_link

Have you read the Contributing Guidelines on issues?

Yes
@pranabdas pranabdas added status: needs triage This issue has not been triaged by maintainers proposal This issue is a proposal, usually non-trivial change labels Aug 8, 2021
@pranabdas pranabdas changed the title TOC item should not be highlighted if not in the viewport TOC item should not be highlighted if below the viewport Aug 10, 2021
@slorber slorber mentioned this issue Aug 10, 2021
Merged
@slorber
Copy link
Collaborator

slorber commented Aug 10, 2021

Thanks, added the TOC to our very long changelog page and can see those issues as well as a few others:

@slorber slorber mentioned this issue Aug 14, 2021
Merged
@slorber
Copy link
Collaborator

slorber commented Aug 14, 2021

fixed in #5361, try canary and let me know if this works fine

cc @sw-yx

@pranabdas
Copy link
Contributor Author

@slorber yes, my issue is fixed. Thank you!

@Josh-Cena Josh-Cena added bug An error in the Docusaurus core causing instability or issues with its execution and removed proposal This issue is a proposal, usually non-trivial change status: needs triage This issue has not been triaged by maintainers labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: refactor TOC highlighting + handle edge cases facebook/docusaurus
3 participants
@slorber @pranabdas @Josh-Cena