Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Changelog page should display TOC with releases #5331

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 10, 2021

Motivation

Hack around the MDX import + TOC issue (#3915) to make sure this doc page displays a TOC.

Also, acts as a "proof of concept workaround" for this issue that others could try.

Having a very long TOC on this page is also helpful to test TOC-related edge-cases, such as #5318 . We can clearly see that there are some weird issues with our TOC highlighting.

https://deploy-preview-5331--docusaurus-2.netlify.app/community/changelog

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 10, 2021
@slorber slorber requested a review from lex111 as a code owner August 10, 2021 17:47
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 10, 2021
@netlify
Copy link

netlify bot commented Aug 10, 2021

✔️ [V2]

🔨 Explore the source changes: 9968be1

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6112bbb38a5afa00078748a5

😎 Browse the preview: https://deploy-preview-5331--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5331--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 36.1 kB
website/build/assets/css/styles.********.css 93.2 kB
website/build/assets/js/main.********.js 403 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 63.9 kB
website/build/blog/index.html 33.1 kB
website/build/docs/index.html 41.9 kB
website/build/docs/installation/index.html 49.6 kB
website/build/index.html 28.7 kB
website/build/tests/docs/index.html 22.6 kB
website/build/tests/docs/standalone/index.html 20.5 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants