Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of forked and to-be-forked dependencies #6246

Open
Josh-Cena opened this issue Jan 2, 2022 · 8 comments
Open

List of forked and to-be-forked dependencies #6246

Josh-Cena opened this issue Jan 2, 2022 · 8 comments
Labels
domain: dependencies Proposal to upgrade a dependency across major versions meta Meta-issue about the project itself. Either project maintenance or a list of other issues.

Comments

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Jan 2, 2022

Docusaurus forked the following dependencies to add our own functionality:

☝️All forks that I'm aware of. Below are some packages we should fork & maintain ourselves:

@Josh-Cena Josh-Cena added the meta Meta-issue about the project itself. Either project maintenance or a list of other issues. label Jan 2, 2022
@slorber
Copy link
Collaborator

slorber commented Jan 5, 2022

Thanks for listing those! Hope we'll get the org soon

@Josh-Cena
Copy link
Collaborator Author

@slorber Any idea why react-loadable-ssr-addon was forked? Did you just publish without committing to your fork? The version on NPM is still what was originally forked though

@slorber
Copy link
Collaborator

slorber commented Jan 5, 2022

I think it's using another branch (the one I used to open the pending PR, not main: themgoncalves/react-loadable-ssr-addon#28 (comment))

https://github.com/slorber/react-loadable-ssr-addon/tree/slorber/fix-webpack5-warning

@slorber
Copy link
Collaborator

slorber commented Mar 4, 2022

For the upcoming GitHub organization, adding this starter that is used in a few places. We may have more starters/example repos later.

https://github.com/slorber/docusaurus-starter

@Josh-Cena Josh-Cena added pr: dependencies Pull requests that update a dependency file domain: dependencies Proposal to upgrade a dependency across major versions and removed pr: dependencies Pull requests that update a dependency file labels Apr 29, 2022
@zpao
Copy link
Member

zpao commented May 5, 2022

How current is this list? Can we switch back to upstream for any of these?

@jpdriver
Copy link
Contributor

jpdriver commented May 5, 2022

hey all 👋🏻 i don't mean to pollute this thread, but just to mention that as the lead maintainer for both react-live and prism-react-renderer I'd love to collaborate on whatever changes would need to be made to keep docusaurus on the latest upstream versions of those libs 🙇🏻‍♂️

@Josh-Cena
Copy link
Collaborator Author

Josh-Cena commented May 6, 2022

How current is this list? Can we switch back to upstream for any of these?

@zpao react-live is being migrated away from in #6589, so it can probably not be forked. prism-react-renderer can probably stay for now. Everything else is still relevant. I've updated the list. We don't have any newly forked dependencies, since we are still waiting for the @Docusaurus org.


@jpdriver Oh, great news! I'm not sure what the status of prism-react-renderer is, I honestly thought it's quasi-dead from the update frequency... I'm going to dump a few issues and possibly PRs in the next few days.

react-live seems to have a React version mismatch, iirc, which is why we are still pinning it to 2.2.3. Has it be fixed over time, or is it only fixable by migrating to v3? I think react-runner seems promising enough—it seems the major advantage of this package, apart from Sucrase (which you are already migrating to in v3), is SSR. Does react-live have plans to support SSR?

@jpdriver
Copy link
Contributor

jpdriver commented May 6, 2022

@Josh-Cena happy to keep chatting here or move to some other venue if there's a more appropriate place!

yep prism-react-renderer hadn't been active for a while, but i'm hoping to change that. i'd be happy to review any issues and PRs you open.

For react-live, the version mismatch issue was resolved with v3. The project did previously support SSR, but unfortunately due to our current usage of Hooks we’ve lost that along the way.

if I’m missing something obvious and there is a way to re-introduce SSR support, i’d love to do that 😅


updated: react-live's SSR regression will be fixed in FormidableLabs/react-live#321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: dependencies Proposal to upgrade a dependency across major versions meta Meta-issue about the project itself. Either project maintenance or a list of other issues.
Projects
None yet
Development

No branches or pull requests

4 participants