Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional external links doesn't appear to work #8

Closed
sdwilsh opened this issue Jul 11, 2017 · 2 comments
Closed

Adding additional external links doesn't appear to work #8

sdwilsh opened this issue Jul 11, 2017 · 2 comments

Comments

@sdwilsh
Copy link
Contributor

sdwilsh commented Jul 11, 2017

In my siteConfig.json:

  /* header links for links outside the site */
  headerLinksExternal: [
    {
      section: "buck",
      href: "https://buckbuild.com",
      text: "Buck"
    },
    {
      section: "github",
      href: "https://github.com/deltice/test-site",
      text: "GitHub"
    }
  ],

Results in this HTML being generated:

<li><a href="https://buckbuild.com" class=""></a></li><li><a href="https://github.com/deltice/test-site" class="">GitHub</a></li>

While the node was created, it doesn't have the text in it. Order doesn't seem to matter; GitHub is always printed, and Buck isn't.

@deltice
Copy link
Contributor

deltice commented Jul 11, 2017

Try deleting the i18n folder and the translations.js file. These files should only be there if translations need to be supported. I'm currently in the middle of changing the translation functionality and the getting started guide, and this issue may be related. For now this will mean you will not be able to support translations, but translation functionality is changing anyway.

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Jul 11, 2017 via email

@deltice deltice closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants