Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 0.0.0.0 for livereload address #919

Closed
tanc opened this issue Aug 27, 2018 · 1 comment · Fixed by #1475
Closed

Use 0.0.0.0 for livereload address #919

tanc opened this issue Aug 27, 2018 · 1 comment · Fixed by #1475
Labels
better engineering Not a bug or feature request difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@tanc
Copy link

tanc commented Aug 27, 2018

🚀 Feature

At the moment live reload is hardcoded to use localhost for its address which stops it working inside a docker container. This request is to change it to 0.0.0.0 to allow livereload to work when visited from the host machine.

Have you read the Contributing Guidelines on issues?

Yes

Motivation

To enable Docusaurus to be containerised it would be handy to have livereload work from outside the container.

Pitch

If a developer is able to view the output of livereload served from within a container then a Docusaurus instance can be packaged in a node based Docker container and a self contained environment can be given to other developers so they can write documentation without having node installed locally.
@tanc tanc mentioned this issue Aug 27, 2018
Closed
@endiliey endiliey added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. better engineering Not a bug or feature request and removed feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. labels Aug 28, 2018
@JoelMarcey JoelMarcey added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Sep 5, 2018
@yangshun yangshun removed the status: claimed Issue has been claimed by a contributor who plans to work on it. label Oct 14, 2018
@maht0rz
Copy link

maht0rz commented Mar 26, 2019

Guys any chance this will be implemented soon?

@endiliey endiliey added difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. labels May 14, 2019
@palmer-cl palmer-cl mentioned this issue May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better engineering Not a bug or feature request difficulty: starter Issues that are starter difficulty level, e.g. minimal tweaking with a clear test plan. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow different host through CLI flag
Use 0.0.0.0 for livereload address tanc/Docusaurus
5 participants
@tanc @yangshun @JoelMarcey @maht0rz @endiliey