Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with highlightjs custom highlighting ignored #1016

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

ersul4ik
Copy link

@ersul4ik ersul4ik commented Oct 4, 2018

Motivation

#960
(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

Yes
(Write your answer here.)

Test Plan

Before changes to the lib/core/renderMarkdown.js code written in solidity looked like this:

3

After adding siteConfig.highlight && siteConfig.highlight.hljs && siteConfig.highlight.hljs(hljs); to the renderMarkdown.js, the problem was resolved.

4

@chenglou found the solution.

Related PRs

None
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Oct 4, 2018

Deploy preview for docusaurus-preview ready!

Built with commit 04e14ee

https://deploy-preview-1016--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 4, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants