Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve last updated time feature #1036

Merged
merged 1 commit into from Oct 14, 2018
Merged

fix: improve last updated time feature #1036

merged 1 commit into from Oct 14, 2018

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Oct 14, 2018

Motivation

  1. Rename some variables
  2. Extract inline styles into CSS
  3. Add try/catch around shell commands

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Test with valid updated time
  2. Throw error within function and see that it's gracefully handled

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 14, 2018
@yangshun yangshun merged commit b577f60 into master Oct 14, 2018
@yangshun yangshun deleted the update branch October 14, 2018 22:05
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 919f4f8

https://deploy-preview-1036--docusaurus-preview.netlify.com

1 similar comment
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 919f4f8

https://deploy-preview-1036--docusaurus-preview.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants