fix: render proper HTML instead of raw markdown in meta description #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2018 17:16
sebqq
changed the title
|
Deploy preview for docusaurus-preview ready! Built with commit 330dd42 |
endiliey
suggested changes
Oct 23, 2018
There was a problem hiding this comment.
Can you use https://opengraphcheck.com and test it with a small test case (before) and (after) result. Post the results as your test plan so we are certain it works
|
Thanks @endiliey! I've just added pictures from Open Graph Check to my Test plan. |
endiliey
changed the title
endiliey
changed the title
endiliey
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A pure markdown text was previously shown in "og:description" and "description" meta tags in Docs. Markdown text should be rendered into the HTML instead. Fixes #1014
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Test by Open Graph Check:
og:description before changes:
og:description after changes:
You should see that content of description is rendered into the raw HTML in
<meta name"description" >and<meta property="og:description" >tags.