fix(v2): map loaded modules to bundles #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 6b663c8 |
endiliey
added
the
status: don't merge yet
endiliey
removed
the
status: don't merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we go to https://munseo-preview.netlify.com/, with 'JavaScript disabled' will break CSS due to SSR code splitting.
Even if javascript is enabled. You might see a flickering/flash due to css not rendered on server side before hand.
See jaredpalmer/after.js#118 for super similar case
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Accessing deploy preview on netlify with 'JavaScript disabled' does not break CSS