Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relative path markdown linking on versioned docs #1281

Merged
merged 1 commit into from Mar 14, 2019

Conversation

endiliey
Copy link
Contributor

Motivation

Fix #1271

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Follow this repo https://github.com/parthpp/Docusaurus-Broken-Links

Before:
before

After:
after

Also strictly enforce docusaurus-version to use X.Y.Z format like Semver, does not allow /

@yangshun
Copy link
Contributor

Deploy preview for munseo-preview ready!

Built with commit 29ed61f

https://deploy-preview-1281--munseo-preview.netlify.com

@endiliey endiliey requested a review from yangshun March 14, 2019 08:02
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@endiliey endiliey merged commit 63f014f into facebook:master Mar 14, 2019
@endiliey endiliey deleted the 1271 branch March 14, 2019 08:03
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 29ed61f

https://deploy-preview-1281--docusaurus-preview.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants