Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change landing page hero #1290

Merged
merged 4 commits into from Mar 20, 2019
Merged

feat: change landing page hero #1290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
716e8a2
docs: add v2 roadmap to landing page
yangshun Mar 20, 2019
44082c5
feat: change landing page hero
yangshun Mar 20, 2019
0fc31d8
fix: remove CSS test as it doesn't account for autoprefixing
yangshun Mar 20, 2019
15fbbed
fix: some css nits
endiliey Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions v1/website/pages/en/index.js
View file
Open in desktop
Expand Up @@ -60,18 +60,18 @@ class Index extends React.Component {
return (
<div>
<HomeSplash siteConfig={siteConfig} language={language} />
<div className="mainContainer">
<div className="announcement">
<div className="announcement-inner">
We're working on{' '}
<a href="https://github.com/facebook/Docusaurus/issues/789">
Docusaurus 2
</a>
, contribute to its roadmap by suggesting features or giving
feedback{' '}
<a href="https://munseo-preview.netlify.com/feedback/">here</a>!
</div>
<div className="announcement">
<div className="announcement-inner">
We're working on{' '}
<a href="https://github.com/facebook/Docusaurus/issues/789">
Docusaurus 2
</a>
, contribute to its roadmap by suggesting features or giving
feedback{' '}
<a href="https://munseo-preview.netlify.com/feedback/">here</a>!
</div>
</div>
<div className="mainContainer">
<Container padding={['bottom', 'top']} background="light">
<GridBlock
align="center"
Expand Down
2 changes: 1 addition & 1 deletion v1/website/static/css/custom.css
View file
Open in desktop
Expand Up @@ -63,8 +63,8 @@ table td:first-child > code {
color: #fff;
font-weight: bold;
font-size: 24px;
margin-top: -40px;
Copy link
Contributor Author

@yangshun yangshun Mar 21, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endiliey I needed this to be there because the mainContainer has a padding of 40px. I was wondering why it appeared there even though I removed it before committing 😞

Without this line, there's a white bar below the announcement.

EDIT: I see that you tried to move it out of the mainContainer but I think it doesn't totally fix the issue.

Screen Shot 2019-03-20 at 8 26 32 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that it displays differently on different browser/ resolution. Doesn’t appear in my browser 😂

padding: 48px;
margin: 0 auto;
text-align: center;
}

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.