refactor: simplify blog url replacement regex #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 49ea62e |
|
Deploy preview for docusaurus-preview ready! Built with commit 49ea62e |
yangshun
suggested changes
May 18, 2019
yangshun
suggested changes
May 18, 2019
|
@yangshun |
yangshun
changed the title
yangshun
approved these changes
May 19, 2019
There was a problem hiding this comment.
Please read the CONTRIBUTING guidelines. It states that the PR titles have to follow a format. We would really appreciate if you read through the PR template more. I've changed it for you here.
I think this looks ok. cc @endiliey
hong4rc
changed the title
|
@yangshun Thank you, This change for |
endiliey
approved these changes
May 19, 2019
endiliey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
/\/index.html$/is wrong, it should be/\/index\.html$//\/index\.html$/and/\.html$/to/(\/index)?\.html$/new RegExp('/', 'g')but I think change it to same other RegExp.replace('-', '/')was called thrice, maybe he want to replace all so I change it to /-/g (I'm wrong here)Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan