Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flag for server port number #15

Merged
merged 1 commit into from Jul 13, 2017
Merged

Use flag for server port number #15

merged 1 commit into from Jul 13, 2017

Conversation

deltice
Copy link
Contributor

@deltice deltice commented Jul 13, 2017

Change server port number specification from a command line argument to a flag "--port".

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 13, 2017
Copy link
Contributor

@ericvicenti ericvicenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom, looks great! Can you make sure to coordinate with @sdwilsh when you release, to make sure you don't break his experience with the previous API?

Also, this should be documented somewhere. We might not have a great place to put it yet, but maybe @JoelMarcey can help.

@deltice
Copy link
Contributor Author

deltice commented Jul 13, 2017

Yup I'll be sure to let Shawn know when this change goes through. Should I publish a new version to npm with just this change or would it be better to accumulate some more changes first?

@ericvicenti
Copy link
Contributor

There is a tradeoff. Frequent updates may be annoying but you also want to get your fixes out quickly.

So its up to you- do whatever serves your clients the best!

@deltice
Copy link
Contributor Author

deltice commented Jul 13, 2017

Okay, for this one I'll publish the new version to add the change.

@deltice deltice merged commit 5058e76 into master Jul 13, 2017
@JoelMarcey
Copy link
Contributor

I think since we are not even really publicly released yet, frequent npm updates is just fine. Anyone using us should know we are still in development/alpha stage at this point.

@deltice deltice deleted the update-start-args branch July 13, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants