fix: reload siteConfig.js automatically when locally served page is refreshed #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit ef84f36 |
|
Deploy preview for docusaurus-preview ready! Built with commit 535fe04 |
1 similar comment
|
Deploy preview for docusaurus-preview ready! Built with commit 535fe04 |
endiliey
commented
May 22, 2019
| @@ -15,7 +15,8 @@ module.exports = { | |||
| testPathIgnorePatterns: [ | |||
| '/node_modules/', | |||
| '__fixtures__', | |||
| '/packages/.*/lib', | |||
There was a problem hiding this comment.
Otherwise it is ignoring the tests on v1. My bad !!
|
Deploy preview for docusaurus-preview ready! Built with commit 6d7818c |
endiliey
commented
May 22, 2019
| const React = require('react'); | ||
| const path = require('path'); | ||
| const fs = require('fs-extra'); | ||
| const metadataUtils = require('./metadataUtils'); | ||
| const {replaceAssetsLink} = require('./utils.js'); | ||
| const {renderToStaticMarkupWithDoctype} = require('./renderUtils'); | ||
| const loadConfig = require('./config'); | ||
|
|
||
| const siteConfig = loadConfig(`${CWD}/siteConfig.js`); |
There was a problem hiding this comment.
less CWD calls >.<
endiliey
commented
May 22, 2019
|
|
||
| const siteConfig = loadConfig(`${CWD}/siteConfig.js`); |
|
Deploy preview for docusaurus-preview ready! Built with commit ef84f36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
An attempt to reduce number of siteconfig require calls on Docusaurus 1. In effect, this made siteConfig.js become reloaded automatically. (Finally we can live reload siteconfig)
Others:
This should Fix #267 #1508
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See the gif below, we can reload siteconfig now for pages, docs and blog
