fix: don't collapse the blog navigation even if collapsible is true #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 516ac3b |
|
Deploy preview for docusaurus-preview ready! Built with commit 516ac3b |
endiliey
suggested changes
May 27, 2019
| @@ -10,6 +10,8 @@ const fs = require('fs'); | |||
| const Container = require('./Container.js'); | |||
| const SideNav = require('./nav/SideNav.js'); | |||
| const Metadata = require('../core/metadata.js'); | |||
|
|
|||
| const siteConfig = require(`${process.cwd()}/siteConfig.js`); | |||
There was a problem hiding this comment.
Can we get the config from passed props ? DocsLayout has config as its props, and we can pass it to DocsSidebar
There was a problem hiding this comment.
Hmm ok sure, edited!
tusharf5
pushed a commit
to tusharf5/Docusaurus
that referenced
this pull request
May 27, 2019
…acebook#1519) * fix: don't collapse the blog navigation even if collapsible is true * fix: read docsSideNavCollapsible from props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses issue on RN website where collapsible sidebar also appears on the Blog:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Docs show collapsing but blog doesn't.
Related PRs
facebook/react-native-website#934