Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong bootstrapped footer social links #1647

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Conversation

endiliey
Copy link
Contributor

@endiliey endiliey commented Jul 10, 2019

Motivation

fix #1644

the bootstrapped footer code doesnt include social links

wrong (outdated?) component is being created during bootstrapping.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

after

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 10, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 545810f

https://deploy-preview-1647--docusaurus-2.netlify.com

@endiliey endiliey changed the title fix: bootstrqpped footer social links fix: wrong bootstrapped footer social links Jul 10, 2019
@endiliey endiliey merged commit b2558ac into master Jul 10, 2019
@endiliey endiliey deleted the endiliey/fix-social branch July 10, 2019 16:45
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 545810f

https://deploy-preview-1647--docusaurus-preview.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social footer links broken
3 participants