Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content aligning breaks at IE11 #1684

Merged
merged 1 commit into from
Jul 21, 2019
Merged

fix: content aligning breaks at IE11 #1684

merged 1 commit into from
Jul 21, 2019

Conversation

huijing
Copy link
Contributor

@huijing huijing commented Jul 21, 2019

Motivation

Fix the layout issue that occurs on IE11.

Fixes #985.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Visual test on Windows machine running IE11.
Windows 10, IE11.6145.17763.0

Related PRs

N.A.

@huijing huijing requested a review from endiliey as a code owner July 21, 2019 04:39
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 21, 2019
@endiliey endiliey requested review from yangshun and wgao19 July 21, 2019 04:40
@endiliey endiliey changed the title Resolve issue #985 (content overflowing container) fix: content aligning breaks at IE v.11 Jul 21, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 4bfdeea

https://deploy-preview-1684--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 4bfdeea

https://deploy-preview-1684--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have IE11 so I can't test it, but this still works in Chrome so it should be good. Thanks @huijing! 😄

@yangshun yangshun changed the title fix: content aligning breaks at IE v.11 fix: content aligning breaks at IE11 Jul 21, 2019
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust singapore css boss

@yangshun yangshun merged commit bd72aac into facebook:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content aligning breaks at IE v.11
5 participants