Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document what should be in .gitignore #1709

Merged
merged 5 commits into from Jul 26, 2019

Conversation

@wgao19
Copy link
Collaborator

commented Jul 26, 2019

Motivation

Addressing #1704, document what should be in .gitignore

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

NA

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@wgao19 wgao19 requested a review from JoelMarcey Jul 26, 2019

@wgao19 wgao19 requested review from endiliey and yangshun as code owners Jul 26, 2019

@wgao19 wgao19 changed the title docs: explain .gitignore for generated site docs: document what should be in .gitignore Jul 26, 2019

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 56e6312

https://deploy-preview-1709--docusaurus-2.netlify.com

1 similar comment
@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 56e6312

https://deploy-preview-1709--docusaurus-2.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 56e6312

https://deploy-preview-1709--docusaurus-preview.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 6e1e1eb

https://deploy-preview-1709--docusaurus-2.netlify.com

@docusaurus-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 6e1e1eb

https://deploy-preview-1709--docusaurus-preview.netlify.com

@endiliey
Copy link
Collaborator

left a comment

yangshun added some commits Jul 26, 2019

@yangshun
Copy link
Member

left a comment

Tip: If you put "Fixes #1704" in your PR summary, the issue will be automatically closed when the PR is merged. I'm not sure if "Addresses" work but "Fixes" definitely works.

Read more: https://help.github.com/en/articles/closing-issues-using-keywords

@yangshun yangshun merged commit 9c1ba2c into master Jul 26, 2019

2 of 4 checks passed

deploy/netlify Deploy preview processing.
Details
netlify/docusaurus-2/deploy-preview Deploy preview processing.
Details
ci/circleci: lint-prettier Your tests passed on CircleCI!
Details
ci/circleci: tests Your tests passed on CircleCI!
Details

@yangshun yangshun deleted the wgao19/docs-dot-gitignore branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.