Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change separateCSS to separateCss in api-site-config #1735

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Change separateCSS to separateCss in api-site-config #1735

merged 1 commit into from
Aug 1, 2019

Conversation

rhythnic
Copy link

@rhythnic rhythnic commented Aug 1, 2019

The correct property, referenced on the "Custom Pages" docs page, is separateCss. Using separateCSS has no effect.

The correct property, referenced on the "Custom Pages" docs page, is `separateCss`.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@rhythnic
Copy link
Author

rhythnic commented Aug 1, 2019

I signed the CLA.

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix!

@yangshun yangshun merged commit f1415b9 into facebook:master Aug 1, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 1489edf

https://deploy-preview-1735--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 1489edf

https://deploy-preview-1735--docusaurus-preview.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants