docs: fix documented type for the cleanUrl option
#1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 32e5975 |
1 similar comment
|
Deploy preview for docusaurus-2 ready! Built with commit 32e5975 |
|
Deploy preview for docusaurus-preview ready! Built with commit 32e5975 |
|
That doesn't seem to work: https://deploy-preview-1775--docusaurus-preview.netlify.com/docs/en/site-config#cleanurl-string I'm not sure why though? |
yangshun
approved these changes
Sep 13, 2019
yangshun
changed the title
cleanUrl optioncleanUrl option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The documented type was wrong, I think.
Have you read the Contributing Guidelines on pull requests?
Well, I have now.
Test Plan
I must admit I haven't verified it because it's so trivial, but build the docs and visit /docs/en/site-config#cleanurl-string.
Related PRs
-