Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase user vector.dev :) #2040

Merged
merged 2 commits into from
Nov 24, 2019
Merged

docs(v2): showcase user vector.dev :) #2040

merged 2 commits into from
Nov 24, 2019

Conversation

binarylogic
Copy link
Contributor

Hi everyone, we wanted to add vector.dev to the showcase. We just recently transitioned our whole site from Gitbook/Hugo to Docusuarus and have been very happy with it. We took full advantage of adding custom components which is very powerful. Thanks for your work on this project!

Signed-off-by: Ben Johnson <bjohnson@binarylogic.com>
@facebook-github-bot
Copy link
Contributor

Hi binarylogic! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 23, 2019

Deploy preview for docusaurus-2 ready!

Built with commit 8445ff5

https://deploy-preview-2040--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 23, 2019

Deploy preview for docusaurus-preview ready!

Built with commit 8445ff5

https://deploy-preview-2040--docusaurus-preview.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @binarylogic! We're very impressed by the site design and the cool custom features as well.

Just a nit - on the upper left hand side of the screenshot there's a "logo" tooltip (probably your cursor was hovering over the logo). Could you take another screenshot? Or we could just use this.

Tip - I used Chrome's built-in screenshot utility to take many of the screenshots you see in the showcase, you might find it more helpful than the OS screenshoting approach.

@yangshun yangshun changed the title chore(v2): Add vector.dev to the showcase :) docs(v2): showcase user vector.dev :) Nov 24, 2019
@endiliey
Copy link
Contributor

CLA need to be signed before merge

@endiliey endiliey added the status: don't merge yet This PR is completed, but we are still waiting for other things to be ready. label Nov 24, 2019
Signed-off-by: Ben Johnson <bjohnson@binarylogic.com>
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 24, 2019
@binarylogic
Copy link
Contributor Author

@yangshun thanks! I didn't realize that. I just pushed an updated preview image.

@endiliey this is done.

Let me know if you need anything else 😄

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, it's so cool! :D

@yangshun yangshun merged commit 3d4d89f into facebook:master Nov 24, 2019
@endiliey endiliey added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo. status: don't merge yet This PR is completed, but we are still waiting for other things to be ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants