perf(v2): improve dev build time by not overwriting file if possible #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: performance
|
Deploy preview for docusaurus-2 ready! Built with commit 2574e11 |
|
Deploy preview for docusaurus-preview ready! Built with commit 2574e11 |
yangshun
approved these changes
Dec 6, 2019
endiliey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cache-loader compares with mtime
And currently, whenever we run new "docusaurus start", we always overwrite a lot of the generated files for the first time, invalidating cache. The next reload is fine, because we have runtime content hash cache.
We can do better by checking If file already exist but its not in runtime cache hash yet, then we try to calculate the content hash and then compare. This is to avoid unnecessary overwrite and we can reuse old file. Thus, cache-loader wont invalidate.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Before ~7s
My next dev server (second run) went down to ~5s
This is minor improvement, but as more metadata is written, this is gonna improve a lot
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)